[llvm][docs] Add Approvals section to GitHub guide #113434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback that when reading the document as a guide, it's odd that it skips right from updating the PR to merging it. The section is a link to the existing Code Review guide's text on the topic. I have updated that to mention required reviewers, which some subprojects do use (libcxx is one) but most don't. Also we use the words "accepted" and "approved" interchangeably, so I've swapped one instance so it's consistent between paragraphs.
Collaborator
Author
|
@JL2210 based on another bit of your feedback. I agree that the code review and github documents should ideally be one document, or perhaps one document for pr authors and one for pr reviewers. But for the moment, linking between them saves us repeating ourselves here. (part of the reason there are two documents is that for a while GitHub was purely hosting and Phabricator was where reviews were done) |
cor3ntin
reviewed
Oct 23, 2024
Collaborator
Author
|
@nickdesaulniers anything to add? |
nickdesaulniers
approved these changes
Oct 31, 2024
smallp-o-p
pushed a commit
to smallp-o-p/llvm-project
that referenced
this pull request
Nov 3, 2024
Based on feedback that when reading the document as a guide, it's odd that it skips right from updating the PR to merging it. The section is a link to the existing Code Review guide's text on the topic. I have updated that to mention required reviewers, which some subprojects do use (libcxx is one) but most don't. Also we use the words "accepted" and "approved" interchangeably, so I've swapped one instance so it's consistent between paragraphs.
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Based on feedback that when reading the document as a guide, it's odd that it skips right from updating the PR to merging it. The section is a link to the existing Code Review guide's text on the topic. I have updated that to mention required reviewers, which some subprojects do use (libcxx is one) but most don't. Also we use the words "accepted" and "approved" interchangeably, so I've swapped one instance so it's consistent between paragraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback that when reading the document as a guide, it's odd that it skips right from updating the PR to merging it.
The section is a link to the existing Code Review guide's text on the topic.
I have updated that to mention required reviewers, which some subprojects do use (libcxx is one) but most don't.
Also we use the words "accepted" and "approved" interchangeably, so I've swapped one instance so it's consistent between paragraphs.